Increase test coverage: Array.prototype.toString #2717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
requested changes
Jan 18, 2019
| @@ -61,3 +61,10 @@ try { | |||
| assert (e.message === "foo"); | |||
| assert (e instanceof ReferenceError); | |||
| } | |||
|
|
|||
| // Checking behavior when undefined is passed to the function | |||
There was a problem hiding this comment.
At this point not an undefined passed to the function. The function's this_argument is undefined.
|
I updated the patch according to the review. |
matedabis
force-pushed
the
to_string
branch
3 times, most recently
from
34ab980 to
c8dd835
Compare
|
Updated the patch:
|
rerobika
reviewed
Jan 23, 2019
| @@ -61,3 +61,12 @@ try { | |||
| assert (e.message === "foo"); | |||
| assert (e instanceof ReferenceError); | |||
| } | |||
|
|
|||
| /* ES 5.1 15.4.4.2 1. */ | |||
| // Checking behavior when the function's this_argument is undefined | |||
There was a problem hiding this comment.
If the related part of the standard is present, than use the following format:
/* ES v5.1, 15.4.4.2.1.
Checking behavior when the function's this_argument is undefined */
|
Changed comment style. |
Branch coverage: Before: 5/6 After: 6/6 JerryScript-DCO-1.0-Signed-off-by: Mate Dabis mdabis@inf.u-szeged.hu
|
Closing PR because of moving to another branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage is measured by the following script, using
--jerry-test-suite --test262 --unittests --jerry-tests:https://github.com/matedabis/jerryscript/blob/gcov_coverage_tester/tests/gcov-tests/gcovtester.py
Branch coverage:
Before: 5/6
After: 6/6
JerryScript-DCO-1.0-Signed-off-by: Mate Dabis mdabis@inf.u-szeged.hu