Skip to content

Ensure that inner classes do not inherit the parent's class HAS_SUPER flag #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

rerobika
Copy link
Member

@rerobika rerobika commented Jan 3, 2019

This patch fixes #2667.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

… flag.

This patch fixes jerryscript-project#2667.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka robertsipka merged commit 1068b07 into jerryscript-project:master Jan 3, 2019
@zherczeg
Copy link
Member

zherczeg commented Jan 8, 2019

Is this a proper fix? What happens with the super flag after the class parsing is completed???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion 'context_p->byte_code_size > (branch_p->offset >> 8)' failed in parser_set_branch_to_current_position
4 participants