Fix possible failure in backtrace info #2608
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related / follow-up to #2606 . |
Make sure to ignore static snapshots when sending backtrace information to the debugger. The `JMEM_SET_NON_NULL_POINTER` macro requires the frame context's `bytecode_header_p` pointer to be a heap pointer, but due to the static snapshot it might not be, causing an assertion failure. JerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu
zherczeg
reviewed
Nov 22, 2018
| @@ -160,7 +160,8 @@ jerry_debugger_send_backtrace (const uint8_t *recv_buffer_p) /**< pointer to the | |||
|
|
|||
| while (frame_ctx_p != NULL && min_depth_offset++ < max_depth) | |||
| { | |||
| if (frame_ctx_p->bytecode_header_p->status_flags & CBC_CODE_FLAGS_DEBUGGER_IGNORE) | |||
| if (frame_ctx_p->bytecode_header_p->status_flags | |||
| & (CBC_CODE_FLAGS_DEBUGGER_IGNORE | CBC_CODE_FLAGS_STATIC_FUNCTION)) | |||
There was a problem hiding this comment.
There is the total frame count computing above, that is probably invalid as well. Maybe @robertsipka scope chain code is affected as well, since parts of the scope chain should be hidden as well.
DanielBallaSZTE
force-pushed
the
fix_static_snapshot_error2
branch
from
f83a578 to
6966695
Compare
|
@DanielBallaSZTE ping. According to @zherczeg 's comment, it seems that this fix may need further changes. Will those be worked on? |
|
@akosthekiss I think this one can be closed now, as this is not a blocker issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to ignore static snapshots when sending backtrace information to the debugger.
JerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu