Add support for function argument initializers. #2571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
requested changes
Oct 26, 2018
| @@ -76,6 +76,9 @@ typedef enum | |||
| #ifndef CONFIG_DISABLE_ES2015_CLASS | |||
| SCAN_STACK_CLASS, /**< class language element */ | |||
| #endif /* !CONFIG_DISABLE_ES2015_CLASS */ | |||
| #ifndef CONFIG_DISABLE_ES2015_FUNCTION_PARAMETER_INITIALIZER | |||
| SCAN_STACK_FUNCTION_PARAMETERS, /**< function parameter initializer */ | |||
| #endif /* CONFIG_DISABLE_ES2015_FUNCTION_PARAMETER_INITIALIZER */ | |||
There was a problem hiding this comment.
Closing comments of #ifndefs should be perfixed with ! (all over the commit).
akosthekiss
added
development
zherczeg
force-pushed
the
argument_initializer
branch
from
8e96969 to
75ce74c
Compare
rerobika
requested changes
Oct 29, 2018
EcmaScript 2015 14.1. Note: arrow functions with default arguments are not supported yet. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
argument_initializer
branch
from
75ce74c to
5562a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EcmaScript 2015 14.1.
Note: arrow functions with default arguments are not supported yet.