target: mbedos5: Modify generate_pins.py #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Marko Fabo mfabo@inf.u-szeged.hu
|
cc @janjongboom |
|
Great, let me review later this week. |
|
@fbmrk @janjongboom what is the progress of this PR? The code looks good, but I am not too familiar with this particular JerryScript target. |
|
There is no activity on this for more than a month. Shall we close it? We can reopen later if needed of course. |
|
I'm waiting for @janjongboom's review. |
janjongboom
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not necessary to evaluate the values of the
PinName's enumerators to generate pins.cpp, it is enough to search for the names of the pins. Generating pins.js is also unnecessary, because it is always ignored.Fixes #1900
JerryScript-DCO-1.0-Signed-off-by: Marko Fabo mfabo@inf.u-szeged.hu