Merge lcache into context

[akosthekiss]

It is superfluous to maintain multiple globals when the whole
reason of context is to keep them in a single place. It also
simplifies initialization and external context creation a bit.

Also removed unused lcache header includes.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

[akosthekiss]

Note: this is the first part of a series of patches about refactoring the context concept.

[LaszloLango]

LGTM

[zherczeg]

Is there a perf change after this patch?

[zherczeg]

I would intorduce a typedef for this or move the comment the line before. Also add a comment that this must be the last member of the context for performance reasons.

[akosthekiss]

I'll move the comment, typedef would be an overkill for this.

[zherczeg]

Is the cache cleared along the context?

[akosthekiss]

Yes, jerry_init clears all the context with memset. Now that lcache is part of the context, it's initialization is also handled there.

[akosthekiss]

The PR has no performance implications (perhaps just some noise in the measurements):

Benchmark	Perf (sec)
3d-cube.js	0.789 -> 0.793 : -0.597%
3d-raytrace.js	1.022 -> 1.021 : +0.129%
access-binary-trees.js	0.558 -> 0.552 : +0.969%
access-fannkuch.js	2.034 -> 2.043 : -0.416%
access-nbody.js	1.064 -> 1.069 : -0.501%
bitops-3bit-bits-in-byte.js	0.485 -> 0.486 : -0.258%
bitops-bits-in-byte.js	0.638 -> 0.635 : +0.515%
bitops-bitwise-and.js	0.921 -> 0.923 : -0.250%
bitops-nsieve-bits.js	1.095 -> 1.101 : -0.556%
controlflow-recursive.js	0.367 -> 0.367 : -0.010%
crypto-aes.js	0.865 -> 0.866 : -0.106%
crypto-md5.js	0.601 -> 0.591 : +1.695%
crypto-sha1.js	0.591 -> 0.582 : +1.619%
date-format-tofte.js	0.717 -> 0.715 : +0.250%
date-format-xparb.js	0.433 -> 0.431 : +0.450%
math-cordic.js	1.157 -> 1.149 : +0.642%
math-partial-sums.js	0.719 -> 0.719 : +0.025%
math-spectral-norm.js	0.534 -> 0.528 : +1.108%
string-base64.js	1.416 -> 1.422 : -0.419%
string-fasta.js	1.337 -> 1.322 : +1.129%
Geometric mean:	+0.273%

Binary sizes (bytes)
a264560:132660
5729317:132660

I'll deal with the comment placement review remark and update the patch.

[akosthekiss]

PR updated according to the review.

[zherczeg]

LGTM