Decrease byte-code's register pressure during preparation of long arguments list #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
added
bug
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-186
branch
from
dfaa186 to
af77915
Compare
|
Looks good |
|
The intrinsic calls were already removed by the #246 PR. |
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-186
branch
from
af77915 to
0c04f09
Compare
|
Pull request is rebased on current master. |
|
lgtm |
…ception handling in opfunc_obj_decl. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan r.ayrapetyan@samsung.com
…operators, so that every iteration passes start and end of loop body. The change makes possible simple notification of byte-code generator about start / end of byte-code generation for an argument. As register values are not passed between byte-code sequences that prepare different arguments, the change would make possible for byte-code generator to reuse registers allocated for the code sequences. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan r.ayrapetyan@samsung.com
… preparation instruction sequence. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan r.ayrapetyan@samsung.com
egavrin
force-pushed
the
Ruben-fix-issue-186
branch
from
0c04f09 to
6e2733d
Compare
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #186