Fix invalid assertion condition in jump opcode handlers #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
added
bug
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-120
branch
from
09626e3 to
d59b17a
Compare
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-120
branch
from
d59b17a to
5f5b771
Compare
| @@ -14,7 +14,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| TIMEOUT=${TIMEOUT:=30} | |||
| TIMEOUT=${TIMEOUT:=1} | |||
There was a problem hiding this comment.
Wouldn't it be too small timeout, maybe 3 or 5 for low performance targets?
There was a problem hiding this comment.
It can be too small, but 3 or 5, actually, also can be too small. The scheme of infinite loops testing seems to be dependent on some random conditions, so it is better to revise it.
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-120
branch
2 times, most recently
from
52a183f to
efb1a12
Compare
|
Regression test is not added in the pull request, as it is |
|
Good to me |
|
lgtm |
|
|
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-120
branch
from
efb1a12 to
5d84b17
Compare
Related issue: #120 JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan r.ayrapetyan@samsung.com
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-120
branch
from
5d84b17 to
89a7449
Compare
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #120