Repository navigation
Fix ecma_op_array_object_set_length method - #1985
Merged
Merged
Conversation
dbatyai
reviewed
Aug 29, 2017
dbatyai
left a comment
dbatyai
left a comment
Member
There was a problem hiding this comment.
Is this condition in lines 161-172 needed at all? Seems to me this is just a duplicate of lines 147-159, that doesn't seem to do anything other, than repeat the same thing. Or am I missing something?
Member
Author
|
@dbatyai As it seems, you are right this condition is unnecessary. I'll update this PR. |
Member
|
As it turns out, it is needed after all, as it can cause side effects. Please keep the original solution. |
So far a freed variable was tested during error flag inspection. This patch fixes it and jerryscript-project#1972 as well. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far a freed variable was tested during error flag inspection.
This patch fixes it and #1972 as well.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu