-
Notifications
You must be signed in to change notification settings - Fork 682
Introduce JERRY_DISABLE_HEAVY_DEBUG preprocessor definition. #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sand1k, could you, please, also add |
Could you also, please, add check
to test-common.h? |
+1 |
May be, we should rename What do you think about this? |
@ruben-ayrapetyan, name, consistent with JERRY_NDEBUG, would be JERRY_NHEAVY_DEBUG, but JERRY_NO_HEAVY_DEBUG looks much more clear for me. So my preference is JERRY_NO_HEAVY_DEBUG :) |
@sand1k, great!
I mean consistency of behaviours =) |
e7649ad
to
a1e767c
Compare
@ruben-ayrapetyan, I've updated the pull request according to your notes. |
(void) node_p; | ||
#endif /* JERRY_NDEBUG */ | ||
#endif /* !JERRY_NO_HEAVY_DEBUG */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we don't need !
, as the corresponding code part is executed if the macro is defined.
a1e767c
to
b48cf05
Compare
@ruben-ayrapetyan, @egavrin, pr was updated. |
2f38f5c
to
608be9e
Compare
@egavrin, please, review. |
@sand1k, please do the |
@LaszloLango, just to make the definition name more clear. |
+1 LGTM |
…p debug version of the engine. Heavy debug is enabled only for unit tests. JerryScript-DCO-1.0-Signed-off-by: Andrey Shitov a.shitov@samsung.com
608be9e
to
a293e21
Compare
lgtm |
Introduce JERRY_HEAVY_DEBUG preprocessor definiton to speed up debug version of the engine.
JERRY_HEAVY_DEBUG is enabled only for unit tests.
Related issue: #180