Skip to content

Implement parseFloat() #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Implement parseFloat() #190

wants to merge 1 commit into from

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented Jun 15, 2015

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com

@dbatyai dbatyai added ecma builtins Related to ECMA built-in routines development Feature implementation labels Jun 15, 2015
@dbatyai dbatyai added this to the Core ECMA features milestone Jun 15, 2015
@galpeter galpeter mentioned this pull request Jun 15, 2015
29 tasks
start++;
}

ecma_number_t *ret_num = ecma_alloc_number ();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ret_num_p

@dbatyai
Copy link
Member Author

dbatyai commented Jun 16, 2015

@egavrin, I've updated the PR.

@egavrin
Copy link
Contributor

egavrin commented Jun 16, 2015

@dbatyai good to me.

}
}

bool sign = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather prefer false here.

@kkristof
Copy link
Contributor

Apart from the nitpicking on the sign the patch looks good.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
@dbatyai
Copy link
Member Author

dbatyai commented Jun 17, 2015

merged: 7508b80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Feature implementation ecma builtins Related to ECMA built-in routines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants