-
Notifications
You must be signed in to change notification settings - Fork 683
Implement parseFloat() #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
start++; | ||
} | ||
|
||
ecma_number_t *ret_num = ecma_alloc_number (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ret_num_p
@egavrin, I've updated the PR. |
@dbatyai good to me. |
} | ||
} | ||
|
||
bool sign = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather prefer false
here.
Apart from the nitpicking on the |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
merged: 7508b80 |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com