Init commit for Date object #184
Conversation
|
I think this patch is nice, and much needed. lgtm. |
| @@ -319,6 +319,7 @@ ecma_gc_mark (ecma_object_t *object_p) /**< object to mark from */ | |||
| case ECMA_INTERNAL_PROPERTY_PRIMITIVE_STRING_VALUE: /* compressed pointer to a ecma_string_t */ | |||
| case ECMA_INTERNAL_PROPERTY_PRIMITIVE_NUMBER_VALUE: /* compressed pointer to a ecma_number_t */ | |||
| case ECMA_INTERNAL_PROPERTY_PRIMITIVE_BOOLEAN_VALUE: /* a simple boolean value */ | |||
| case ECMA_INTERNAL_PROPERTY_PRIMITIVE_DATE_VALUE: /* compressed pointer to a ecma_date_t */ | |||
There was a problem hiding this comment.
Is the ecma_date_t defined anywhere?
|
This PR is OK for me. @ruben-ayrapetyan do you have any comments? P.S. I like the idea of push skeleton of Date builtin, first - this should should simplify further development and merging. |
| */ | ||
| static ecma_completion_value_t | ||
| ecma_builtin_date_prototype_set_time (ecma_value_t this_arg, /**< this argument */ | ||
| ecma_value_t arg) /**< routine's argument */ |
There was a problem hiding this comment.
Maybe, it is better to replace routine's argument with name of argument, used in specification - for the case it would be time.
|
@ruben-ayrapetyan, I've updated the PR. Please check. |
| @@ -0,0 +1,718 @@ | |||
| /* Copyright 2014-2015 Samsung Electronics Co., Ltd. | |||
There was a problem hiding this comment.
Seems that there should be Copyright 2015, as the file is created in 2015 year.
|
After fixing copyright dates, the changes would be ok for me. |
|
@ruben-ayrapetyan, ok. I'll do it before merge. |
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan szledan.u-szeged@partner.samsung.com JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan szledan.u-szeged@partner.samsung.com
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com