Remove needless toolchain files and variable settings. #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
force-pushed
the
remove_needless_toolchains
branch
2 times, most recently
from
eeb4122 to
994ce26
Compare
akosthekiss
added
enhancement
robertsipka
force-pushed
the
remove_needless_toolchains
branch
from
994ce26 to
00fcf92
Compare
|
LGTM |
1 similar comment
|
LGTM |
Unnecessary to set CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR, these values are set by default. It also allows to use any C99-compliant compiler by using the default CC enviroment variable or by setting the CMAKE_C_COMPILER value using the build script's --cmake-param argument. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
remove_needless_toolchains
branch
from
00fcf92 to
1b996a9
Compare
|
Thanks, I've rebased it with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unnecessary to set CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR set, these values are set by default.
Its also able to use any C99-compliant compiler bye use the default CC enviroment variable or set the
CMAKE_C_COMPILER value using the build script cmake-param argument.
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com