Remove compact profile. #1238
Merged
Remove compact profile. #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
force-pushed
the
remove_compact_profile
branch
from
1e33563 to
e0ce691
Compare
|
|
||
| * 4-byte (float, compact profile) | ||
| * 8-byte (double, full profile) | ||
| The default is 8-byte (double), but its able to use 4-byte (set CONFIG_ECMA_NUMBER_TYPE value), with the risk that it could lead inaccuracies. |
There was a problem hiding this comment.
split this into two lines.
but the engine supports the 4-byte (single precision) representation by setting CONFIG_ECMA_NUMBER_TYPE as well
|
Good patch, LGTM after those stlye fixes. |
robertsipka
force-pushed
the
remove_compact_profile
branch
2 times, most recently
from
21222eb to
38328ee
Compare
|
Thanks, I've updated the patch based on your comments. |
|
LGTM |
1 similar comment
|
LGTM |
The standard doesn't defines ECMAScript Compact Profile as a subset of Ecma-262 Edition 5.1. Profile modes can be added easily like the minimal profile if required. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
remove_compact_profile
branch
from
38328ee to
f15e7be
Compare
|
Thanks, I've rebased it with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard doesn't defines ECMAScript Compact Profile as a subset of Ecma-262 Edition 5.1.
Profile modes can be added easily like the minimal profile if required.
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com