Skip to content

Remove arbitrary case conversion tests. #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Remove arbitrary case conversion tests. #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions jerry-core/lit/lit-char-helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,13 +482,6 @@ lit_char_to_lower_case (ecma_char_t character, /**< input character value */
return 1;
}

if (character == 0x130)
{
output_buffer_p[0] = LIT_CHAR_LOWERCASE_I;
output_buffer_p[1] = 0x307;
return 2;
}

output_buffer_p[0] = character;
return 1;
} /* lit_char_to_lower_case */
Expand Down Expand Up @@ -516,21 +509,6 @@ lit_char_to_upper_case (ecma_char_t character, /**< input character value */
return 1;
}

if (character == 0xdf)
{
output_buffer_p[0] = LIT_CHAR_UPPERCASE_S;
output_buffer_p[1] = LIT_CHAR_UPPERCASE_S;
return 2;
}

if (character == 0x1fd7)
{
output_buffer_p[0] = 0x399;
output_buffer_p[1] = 0x308;
output_buffer_p[2] = 0x342;
return 3;
}

output_buffer_p[0] = character;
return 1;
} /* lit_char_to_upper_case */
8 changes: 0 additions & 8 deletions tests/jerry/string-upper-lower-case-conversion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@ assert ("0123456789abcdefghijklmnopqrstuvwxzyABCDEFGHIJKLMNOPQRSTUVWXYZ".toLower
assert ("0123456789abcdefghijklmnopqrstuvwxzyABCDEFGHIJKLMNOPQRSTUVWXYZ".toUpperCase()
== "0123456789ABCDEFGHIJKLMNOPQRSTUVWXZYABCDEFGHIJKLMNOPQRSTUVWXYZ");

assert ("\u0130".toLowerCase() == "i\u0307");
assert ("\xdf".toUpperCase() == "SS");
assert ("\u1fd7".toUpperCase() == "\u0399\u0308\u0342");

assert ("H\u0130-+".toLowerCase() == "hi\u0307-+");
assert ("\xdf\u1fd7\xdf".toUpperCase() == "SS\u0399\u0308\u0342SS");
assert ("\u0130\u0130\u0130".toLowerCase() == "i\u0307i\u0307i\u0307");

// Although codepoint 0x10400 and 0x10428 are an upper-lowercase pair,
// we must not do their conversion in JavaScript. We must also ignore
// stray surrogates.
Expand Down