Create extended objects instead of internal properties. #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| static ecma_object_t * | ||
| ecma_builtin_make_function_object_for_routine (ecma_builtin_id_t builtin_id, /**< identifier of built-in object | ||
| that initially contains property |
There was a problem hiding this comment.
I know it is not new code, but please fix the style of the comments. Write * on every line
|
LGTM |
zherczeg
force-pushed
the
extended_object
branch
from
d018106 to
47de3b1
Compare
|
LGTM |
Several internal properties are removed and directly stored as part of the object. Faster built-in and JS function processing. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
extended_object
branch
from
47de3b1 to
1726bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several internal properties are removed and directly stored as
part of the object. Faster built-in and JS function processing.
Small performance improvement overall (0.5%) but controlflow-recursive which is call heavy is improved by 6%. Dynamic memory allocation is improved as well, 3d-cube 24K allocation is reduced to 16K. Overall 2.8% malloc improvement.