Optimize conditional jumps. #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| inline ecma_value_t __attr_pure___ __attr_always_inline___ | ||
| ecma_invert_boolean_value (ecma_value_t value) /**< ecma value */ | ||
| { | ||
| JERRY_STATIC_ASSERT ((ECMA_SIMPLE_VALUE_FALSE | 0x1) == ECMA_SIMPLE_VALUE_TRUE |
There was a problem hiding this comment.
This static assert should be right after the definition of ECMA_SIMPLE_VALUE_TRUE and ECMA_SIMPLE_VALUE_FALSE.
There was a problem hiding this comment.
You cannot do that because they are in the header. And only this function depends on this condition at the moment.
There was a problem hiding this comment.
OK, at least move out of the function. IMHO, it should be placed at the top of the file like in ecma-helpers.c
zherczeg
force-pushed
the
relational_improvements
branch
from
eacc295 to
7895cd5
Compare
|
Thank you, fixed. |
|
LGTM |
The ecma_op_to_boolean return value is changed to bool for faster evaluation, and no need to swap operandos of relational compare. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
relational_improvements
branch
from
7895cd5 to
f24be95
Compare
|
Moved to the beginning |
|
@zherczeg, thanks for the update. LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ecma_op_to_boolean return value is changed to bool for faster
evaluation, and no need to swap operandos of relational compare.