Add symbolic constants for vm opcode flags #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,12 +29,25 @@ | |||
| * @{ | |||
| */ | |||
|
|
|||
| /** | |||
| * Shift for extracting the type of getting input data. | |||
There was a problem hiding this comment.
The description of these four macros is a bit hard to grasp. Would be nice to have them improved. Otherwise, the newly introduced macros look good.
There was a problem hiding this comment.
I think we usually write "position" instead of "shift".
|
LGTM |
zherczeg
force-pushed
the
pre_post_increment_fixes
branch
from
a70d230 to
cfb2a40
Compare
|
Reworked the patch. Binary is reduced by 220 bytes. |
| /** | ||
| * Each CBC opcode is transformed to three vm opcodes: | ||
| * | ||
| * - first opcode is a "get arguments" opcode which specify |
There was a problem hiding this comment.
typo: specify -> specifies (three occurences)
There was a problem hiding this comment.
was this comment ignored intentionally?
zherczeg
force-pushed
the
pre_post_increment_fixes
branch
from
cfb2a40 to
ba53d04
Compare
|
Patch refocused a bit, and the description is aligned for the new focus. |
zherczeg
force-pushed
the
pre_post_increment_fixes
branch
from
ba53d04 to
9532380
Compare
|
Still LGTM |
|
LGTM |
and comments. Space consumed by opcode triplets are reduced to 16 bits down from 32 bits. This reduces the opcode triplet tables by 220 bytes. New symbolic constants and defines were also added to describe common operations. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
pre_post_increment_fixes
branch
from
9532380 to
12a58e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1057.