-
Notifications
You must be signed in to change notification settings - Fork 683
Implement Object.isExtensible and Object.preventExtensions function #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,10 +176,24 @@ ecma_builtin_object_object_freeze (ecma_value_t this_arg, /**< 'this' argument * | |
* Returned value must be freed with ecma_free_completion_value. | ||
*/ | ||
static ecma_completion_value_t | ||
ecma_builtin_object_object_prevent_extensions (ecma_value_t this_arg, /**< 'this' argument */ | ||
ecma_builtin_object_object_prevent_extensions (ecma_value_t this_arg __attr_unused___, /**< 'this' argument */ | ||
ecma_value_t arg) /**< routine's argument */ | ||
{ | ||
ECMA_BUILTIN_CP_UNIMPLEMENTED (this_arg, arg); | ||
ecma_completion_value_t ret_value = ecma_make_empty_completion_value (); | ||
|
||
if (!ecma_is_value_object (arg)) | ||
{ | ||
ret_value = ecma_make_throw_obj_completion_value (ecma_new_standard_error (ECMA_ERROR_TYPE)); | ||
} | ||
else | ||
{ | ||
ecma_object_t *obj_p = ecma_get_object_from_value (arg); | ||
ecma_set_object_extensible (obj_p, false); | ||
|
||
ret_value = ecma_make_normal_completion_value (ecma_copy_value (arg, true)); | ||
} | ||
|
||
return ret_value; | ||
} /* ecma_builtin_object_object_prevent_extensions */ | ||
|
||
/** | ||
|
@@ -224,10 +238,27 @@ ecma_builtin_object_object_is_frozen (ecma_value_t this_arg, /**< 'this' argumen | |
* Returned value must be freed with ecma_free_completion_value. | ||
*/ | ||
static ecma_completion_value_t | ||
ecma_builtin_object_object_is_extensible (ecma_value_t this_arg, /**< 'this' argument */ | ||
ecma_builtin_object_object_is_extensible (ecma_value_t this_arg __attr_unused___, /**< 'this' argument */ | ||
ecma_value_t arg) /**< routine's argument */ | ||
{ | ||
ECMA_BUILTIN_CP_UNIMPLEMENTED (this_arg, arg); | ||
ecma_completion_value_t ret_value = ecma_make_empty_completion_value (); | ||
|
||
if (!ecma_is_value_object (arg)) | ||
{ | ||
ret_value = ecma_make_throw_obj_completion_value (ecma_new_standard_error (ECMA_ERROR_TYPE)); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please, update according to the note above. |
||
else | ||
{ | ||
ecma_object_t *obj_p = ecma_get_object_from_value (arg); | ||
|
||
bool extensible = ecma_get_object_extensible (obj_p); | ||
|
||
ret_value = ecma_make_simple_completion_value (extensible | ||
? ECMA_SIMPLE_VALUE_TRUE | ||
: ECMA_SIMPLE_VALUE_FALSE); | ||
} | ||
|
||
return ret_value; | ||
} /* ecma_builtin_object_object_is_extensible */ | ||
|
||
/** | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// Copyright 2015 Samsung Electronics Co., Ltd. | ||
// Copyright 2015 University of Szeged. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
// New objects are extensible. | ||
var empty = {}; | ||
assert (Object.isExtensible(empty) === true); | ||
|
||
// ...but that can be changed. | ||
Object.preventExtensions(empty); | ||
assert(Object.isExtensible(empty) === false); | ||
|
||
// Call on undefined should throw TypeError. | ||
try | ||
{ | ||
Object.isExtensible(undefined); | ||
assert (false); | ||
} catch (e) { | ||
assert (e instanceof TypeError); | ||
} | ||
|
||
try | ||
{ | ||
Object.preventExtensions(undefined); | ||
assert (false); | ||
} catch (e) { | ||
assert (e instanceof TypeError); | ||
} | ||
|
||
// The functions below are unimplemented. | ||
// Sealed objects are by definition non-extensible. | ||
// var sealed = Object.seal({}); | ||
// assert(Object.isExtensible(sealed) === false); | ||
|
||
// Frozen objects are also by definition non-extensible. | ||
// var frozen = Object.freeze({}); | ||
// assert(Object.isExtensible(frozen) === false); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you, please, remove the
return ret_value
and put rest of the function up toreturn
toelse
block?