Unified the commenting form of the internal properties and removed th… #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * RegExp bytecode array | ||
| */ | ||
| ECMA_INTERNAL_PROPERTY_REGEXP_BYTECODE, | ||
| ECMA_INTERNAL_PROPERTY_REGEXP_BYTECODE, /**< RegExp bytecode array */ |
There was a problem hiding this comment.
Move this to ECMA_INTERNAL_PROPERTY_CODE_BYTECODE
There was a problem hiding this comment.
I've changed the order.
robertsipka
force-pushed
the
remove_unused_internal_properties
branch
from
e81513d to
dda2e28
Compare
| @@ -120,59 +120,39 @@ typedef uint32_t ecma_value_t; | |||
| typedef enum | |||
| { | |||
| ECMA_INTERNAL_PROPERTY_CLASS, /**< [[Class]] */ | |||
| ECMA_INTERNAL_PROPERTY_PROTOTYPE, /**< [[Prototype]] */ | |||
| ECMA_INTERNAL_PROPERTY_EXTENSIBLE, /**< [[Extensible]] */ | |||
| ECMA_INTERNAL_PROPERTY_SCOPE, /**< [[Scope]] */ | |||
| ECMA_INTERNAL_PROPERTY_PARAMETERS_MAP, /**< [[ParametersMap]] */ | |||
| ECMA_INTERNAL_PROPERTY_CODE_BYTECODE, /**< first part of [[Code]] - compressed pointer to bytecode array */ | |||
There was a problem hiding this comment.
Update comment: pointer to compact bytecode array
robertsipka
force-pushed
the
remove_unused_internal_properties
branch
from
dda2e28 to
40017fd
Compare
| case ECMA_INTERNAL_PROPERTY_PROTOTYPE: /* the property's value is located in ecma_object_t | ||
| * (see above in the routine) */ | ||
| case ECMA_INTERNAL_PROPERTY_EXTENSIBLE: /* the property's value is located in ecma_object_t | ||
| * (see above in the routine) */ | ||
| case ECMA_INTERNAL_PROPERTY__COUNT: /* not a real internal property type, |
There was a problem hiding this comment.
This case has a very strange placement (to me, at least). Usually, such an "impossible" case comes last in a switch. Anyone else for or against moving this to the end?
robertsipka
force-pushed
the
remove_unused_internal_properties
branch
from
40017fd to
8de4b28
Compare
|
LGTM |
robertsipka
force-pushed
the
remove_unused_internal_properties
branch
from
8de4b28 to
0e8a42c
Compare
| @@ -322,6 +305,12 @@ ecma_gc_mark_property (ecma_property_t *property_p) /**< property */ | |||
|
|
|||
| break; | |||
| } | |||
| case ECMA_INTERNAL_PROPERTY__COUNT: /* not a real internal property type, | |||
| * but number of the real internal property types */ | |||
|
LGTM after my comment is fixed. :) |
…e unused types. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
remove_unused_internal_properties
branch
from
0e8a42c to
3de4170
Compare
|
Thanks, I've updated this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e unused types.
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com