Check whether the aligned pointers value of the internal properties c… #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
force-pushed
the
internal_property
branch
from
85a7552 to
3230b03
Compare
|
Please fix the format of the commit message. |
robertsipka
force-pushed
the
internal_property
branch
from
3230b03 to
e6f92b5
Compare
|
Sure, I've updated the commit message. |
|
Patch is ok, but I would prefer a bit better description of the commit message. |
…an be stored directly in ecma_value_t. Those internal properties which have a primitive value field or where the property value type is an ecma_object_t ptr were checked earlier. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
internal_property
branch
from
e6f92b5 to
19b972b
Compare
|
Thanks for the review, I've updated the commit message, and I've rebased this patch with the current master. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…an be stored directly
in ecma_value_t or not.
This change affects those internal properties that haven't been checked previously.
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com