Don't use pointer compression where the ecma_value can store pointer … #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
force-pushed
the
internal_property
branch
4 times, most recently
from
d6b1156 to
019d92b
Compare
LaszloLango
added
enhancement
|
|
| @@ -315,7 +315,8 @@ ecma_gc_mark_property (ecma_property_t *property_p) /**< property */ | |||
| case ECMA_INTERNAL_PROPERTY_SCOPE: /* a lexical environment */ | |||
| case ECMA_INTERNAL_PROPERTY_PARAMETERS_MAP: /* an object */ | |||
| { | |||
| ecma_object_t *obj_p = ECMA_GET_NON_NULL_POINTER (ecma_object_t, property_value); | |||
|
|
|||
| ecma_object_t *obj_p = ecma_get_object_from_value (property_value); | |||
There was a problem hiding this comment.
Unfortunately this is still a slow-down, since you also add object flags to the value. I would still prefer a variant to the ECMA_GET_NON_NULL_POINTER macro.
ECMA_INTERNAL_VALUE_GET_POINTER / ECMA_INTERNAL_VALUE_SET_POINTER
robertsipka
force-pushed
the
internal_property
branch
3 times, most recently
from
2ce61c1 to
e84dad6
Compare
|
Thanks, I've updated the patch based on your comment. |
| * Set an internal property value of non-null pointer so that it will correspond | ||
| * to specified non_compressed_pointer. | ||
| */ | ||
| #define ECMA_SET_INTERNAL_VALUE_POINTER(field, non_compressed_pointer) ECMA_SET_NON_NULL_POINTER(field, \ |
There was a problem hiding this comment.
I would prefer
#define ECMA_SET_INTERNAL_VALUE_POINTER(field, non_compressed_pointer) \
ECMA_SET_NON_NULL_POINTER((field), (non_compressed_pointer))
d1e0e3b to
8cf7c44
Compare
|
I've rebase with master. |
| /** | ||
| * Set an internal property value of pointer | ||
| */ | ||
| #define ECMA_SET_INTERNAL_VALUE_POINTER(field, pointer) field = (ecma_value_t) pointer; |
There was a problem hiding this comment.
I'd use similar style for the macro like below.
#define ECMA_SET_INTERNAL_VALUE_POINTER(field, non_compressed_pointer) \
field = (ecma_value_t) non_compressed_pointer
robertsipka
force-pushed
the
internal_property
branch
3 times, most recently
from
963e951 to
f3a942b
Compare
…value directly. This changes affects those internal properties where the property value type is an ecma_object_t ptr. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
|
LGTM |
robertsipka
force-pushed
the
internal_property
branch
from
f3a942b to
ec19294
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…value directly.
This changes affects those internal properties where the property value type is an ecma_object_t ptr.
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com