Skip to content

Unifiy the comments of preprocessor conditionals #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akosthekiss
Copy link
Member

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

@akosthekiss akosthekiss added bug Undesired behaviour style Related to coding style labels Apr 18, 2016
@akosthekiss
Copy link
Member Author

As discussed at #1015 . This is not necessarily the final version, but consistent at least.

Why I'm saying it's not necessarily the final version: the comments after #endifs look sometimes weird if preceeded by an #else or #elif preprocessor directive. One could argue that the final comment of an #endif could repeat that of its directly preceeding directive, i.e., not necessarily the predicate of the #if. E.g.,

#ifdef XXX
#endif /* XXX */

#ifndef XXX
#endif /* !XXX */

#if XXX
#elif YYY
#elif ZZZ
#else /* !XXX && !YYY & !ZZZ */
#endif /* !XXX && !YYY & !ZZZ */

But that's really just a matter of style. Right now, the PR goes with the originally suggested style. Happy to change it however the reviewers vote. Just let's get it consitent.

@zherczeg
Copy link
Member

This is ok for me. LGTM

@LaszloLango
Copy link
Contributor

Thanks for cleaning up this. LGTM

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
@akosthekiss akosthekiss merged commit 3a8d3b3 into jerryscript-project:master Apr 18, 2016
@akosthekiss akosthekiss deleted the preproc-comments branch April 18, 2016 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour style Related to coding style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants