Skip to content

Precommit fails after expanding magic string API #161

Closed
@bzsolt

Description

@bzsolt

After [723924f]](seanshpark@723924f) the precommit fails with the following message:

.../tests/unit/test_api.cpp:452:65: error: conversion to ‘uint32_t {aka unsigned int}’ from ‘long unsigned int’ may alter its value [-Werror=conversion]
   uint32_t num_magic_string_items = sizeof (magic_string_items) / sizeof (jerry_api_char_ptr_t);

Here is the mentoined line: L452
Refer: #136

Metadata

Metadata

Assignees

No one assigned

    Labels

    criticalRaises security concerns

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions