Assertion 'ecma_get_value_type_field (value) == ECMA_TYPE_OBJECT' failed in ecma_get_object_from_value

[renatahodovan]

Jerry version:

Checked revision: 77df022
Build: debug.linux

OS:

Ubuntu 14.04, x86_64

Test case:

Object.defineProperties([], undefined);

Backtrace:

ICE: Assertion 'ecma_get_value_type_field (value) == ECMA_TYPE_OBJECT' failed at jerryscript/jerry-core/ecma/base/ecma-helpers-value.cpp(ecma_get_object_from_value):316.
Error: ERR_FAILED_INTERNAL_ASSERTION
[Inferior 1 (process 19980) exited with code 0170]
(gdb) bt
#0  ecma_get_object_from_value (value=4) at jerryscript/jerry-core/ecma/base/ecma-helpers-value.cpp:316
#1  0x0000000000496649 in ecma_builtin_object_object_define_properties(unsigned int, unsigned int, unsigned int) [clone .19528] (this_arg=59, 
    arg1=131, arg2=4) at jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-object.cpp:343
#2  0x00000000004a23e9 in ecma_builtin_object_dispatch_routine (builtin_routine_id=51, this_arg_value=59, 
    arguments_list=0x82b6d0 <_ZL13mem_heap_area.4015+262032>, arguments_number=2)
    at jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-object.inc.h:72
#3  0x00000000004aafd5 in ecma_builtin_dispatch_routine (builtin_object_id=ECMA_BUILTIN_ID_OBJECT, builtin_routine_id=51, this_arg_value=59, 
    arguments_list=0x82b6d0 <_ZL13mem_heap_area.4015+262032>, arguments_number=2)
    at jerryscript/jerry-core/ecma/builtin-objects/ecma-builtins.inc.h:29
#4  0x00000000004aa7a3 in ecma_builtin_dispatch_call (obj_p=0x7eb7f8 <_ZL13mem_heap_area.4015+184>, this_arg_value=59, 
    arguments_list_p=0x82b6d0 <_ZL13mem_heap_area.4015+262032>, arguments_list_len=2)
    at jerryscript/jerry-core/ecma/builtin-objects/ecma-builtins.cpp:398
#5  0x00000000004697e4 in ecma_op_function_call (func_obj_p=0x7eb7f8 <_ZL13mem_heap_area.4015+184>, this_arg_value=59, 
    arguments_list_p=0x82b6d0 <_ZL13mem_heap_area.4015+262032>, arguments_list_len=2)
    at jerryscript/jerry-core/ecma/operations/ecma-function-object.cpp:684
#6  0x0000000000458c63 in opfunc_call_n (opdata=..., int_data=0x7fffffffd560) at jerryscript/jerry-core/vm/opcodes.cpp:710
#7  0x00000000004c1a11 in vm_loop (int_data=0x7fffffffd560) at jerryscript/jerry-core/vm/vm.cpp:452
#8  0x00000000004b86e5 in vm_run_from_pos (start_pos=1, this_binding_value=15, lex_env_p=0x7eb770 <_ZL13mem_heap_area.4015+48>, is_strict=false, 
    is_eval_code=false) at jerryscript/jerry-core/vm/vm.cpp:528
#9  0x00000000004c17df in vm_run_global () at jerryscript/jerry-core/vm/vm.cpp:383
#10 0x00000000004bf487 in jerry_run () at jerryscript/jerry-core/jerry.cpp:1243
#11 0x00000000004bdab6 in main (argc=2, argv=0x7fffffffd908) at jerryscript/main-linux.cpp:248

[ruben-ayrapetyan]

@kkristof, please, check.

[kkristof]

The issue was caused the lack of checking whether the properties is undefined or null.
Possible fix in #137

[galpeter]

@renatahodovan, could you verify that the current master now works as expected?

[renatahodovan]

@galpeter, it's working fine. Thanks!

[galpeter]

Thanks, closing as fixed.