Fix string length computation in iotjs::WrapEval #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As motivated by @zherczeg in jerryscript-project/jerryscript#813 |
|
LGTM |
1 similar comment
|
LGTM |
The iotjs::String constructor automatically allocates at least size+1 bytes for the data (that +1 byte for the terminating zero), so there is no need for the +1 on the caller side. Moreover, strcpy can work just as fine as strcat in this case, since caller knows where the first string ends, so there is no need to make strcat figure that out. IoT.js-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
akosthekiss
force-pushed
the
wrapeval-lens
branch
from
33f6095 to
dfdc98d
Compare
pmarcinkiew
pushed a commit
to pmarcinkiew/iotjs
that referenced
this pull request
Aug 29, 2017
Added FTP server sample application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iotjs::String constructor automatically allocates at least
size+1 bytes for the data (that +1 byte for the terminating zero),
so there is no need for the +1 on the caller side.
Moreover, strcpy can work just as fine as strcat in this case,
since caller knows where the first string ends, so there is no need
to make strcat figure that out.
IoT.js-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu