Create a version of get_or_insert that doesn't move the key #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also accept suggestions on better names for these methods. |
|
Changes look good! Mind just adding a test for the method as well? |
|
Done. I added the missing methods, and documentation and tests for all of them. |
lufte
changed the title
|
@lufte apologies for the delay getting back to this, mind addressing the issues from CI? |
|
No worries. All done, it was just a matter of running cargo fmt. |
Four new methods are added: * get_or_insert_ref * try_get_or_insert_ref * get_or_insert_mut_ref * try_get_or_insert_mut_ref which are analog to their existing counterparts: * get_or_insert * try_get_or_insert * get_or_insert_mut * try_get_or_insert_mut with the difference of accepting a reference to the key instead of an owned object. If the key doesn't exist in the cache and needs to be moved, only then is it cloned using to_owned() so it can be owned by the cache. This is useful when cloning the key is expensive.
|
Oops, missed that one. I squashed everything to avoid having some many little commits related to linting and test fixing. |
|
Looks great, thanks for the contribution @lufte! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_or_insertis handy but expensive when K is a non-copy type, as it needs to take ownership of the key even when it's already in the cache. This version takes a reference toKand only if it doesn't exist, will it clone it (viaToOwned) and put it in the cache.If this addition is acceptable, I will create the missing counterparts to
get_or_insert_mut,try_get_or_insert, andtry_get_or_insert_mut; as well as the documentation for every method.I'm really not used to writing much "library code" (with lots of Trait requirements) in Rust, nor unsafe code, so I would really appreciate a careful review from you; although it's pretty much a copy of
get_or_insertwith just a couple of changes.