Skip to content

Add option to download static libv8 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2020
Merged

Add option to download static libv8 #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f6ba40
Enable automatic downloading of libv8 on Linux
jeroen Oct 26, 2020
e24a888
Download with R
jeroen Oct 26, 2020
38f4ba3
Update Travis, NEWS
jeroen Oct 26, 2020
21bd95b
Add comments
jeroen Oct 26, 2020
094ec29
Wording
jeroen Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ matrix:
addons:
apt:
packages: libnode-dev
- dist: bionic
env: DOWNLOAD_STATIC_LIBV8=1
- os: osx
brew_packages: v8
- os: osx
Expand Down
6 changes: 6 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
3.3.2
- When setting envvar DOWNLOAD_STATIC_LIBV8=1 on Linux at build-time, the
configure script automatically downloads a static libv8, instead of looking
for libv8 on the system. This allows the package to be installed on distros
that do not have libv8 (you need at least gcc-5 for this to work).

3.3.1
- Fix a bug in the configure script

Expand Down
8 changes: 8 additions & 0 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ elif [[ "$OSTYPE" == "darwin"* ]]; then
V8HOME="$BREWDIR/opt/$PKG_BREW_NAME"
PKG_CFLAGS="-I${V8HOME}/include -I${V8HOME}/libexec/include"
PKG_LIBS="-L${V8HOME}/libexec $PKG_LIBS"
elif [ "$DOWNLOAD_STATIC_LIBV8" ]; then
# This requires at least GCC-5, i.e. anything except for centos-7
${R_HOME}/bin/R -e 'download.file("http://jeroen.github.io/V8/v8-8.3.110.13-linux.tar.gz", "libv8.tar.gz")'
tar xzf libv8.tar.gz
PKG_CFLAGS="-I${PWD}/v8/include"
PKG_LIBS="-L${PWD}/v8/lib -lv8_monolith"
fi

# For debugging
Expand All @@ -65,6 +71,8 @@ if [ $? -ne 0 ]; then
echo " * rpm: $PKG_RPM_NAME (Fedora, EPEL)"
echo " * brew: $PKG_BREW_NAME (OSX)"
echo " * csw: $PKG_CSW_NAME (Solaris)"
echo "On Linux you can also set env variable DOWNLOAD_STATIC_LIBV8=1 to"
echo " automatically download a static version of libv8."
echo "To use a custom libv8, set INCLUDE_DIR and LIB_DIR manually via:"
echo "R CMD INSTALL --configure-vars='INCLUDE_DIR=... LIB_DIR=...'"
echo "---------------------------[ ERROR MESSAGE ]----------------------------"
Expand Down