ci: remove dict_parser step in publish, add back dictionaries

jeroen-meijer · Jul 26, 2020 · 561058e · 561058e
1 parent 3840dbf
commit 561058e
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 21 deletions.
diff --git a/.github/workflows/publish_web.yaml b/.github/workflows/publish_web.yaml
@@ -7,8 +7,6 @@ on:
 jobs:
   publish_web:
     runs-on: ubuntu-latest
-    container:
-      image: google/dart:2.8.4
     env:
       APP_WORKING_DIRECTORY: ./app/
       BUILD_DIR: ./app/build/web/
@@ -22,9 +20,6 @@ jobs:
           channel: beta
           flutter-version: 1.20.0-7.2.pre
 
-      - name: Run dict_parser
-        run: ./tool/ci/run_dict_parser.sh
-
       - name: Install app dependencies
         run: flutter pub get
         working-directory: ${{ env.APP_WORKING_DIRECTORY }}

diff --git a/README.md b/README.md
@@ -58,7 +58,9 @@
 
 # How to launch
 
-## 1. Run the dictionary parser
+## 1. (Optional) Run the dictionary parser
+
+This repository comes with a pre-made Japanese dictionary file (`app/assets/dicts/dict_ja.json`).
 
 A dictionary parser can be found in the `/dict_parser` directory.
 It currently only supports parsing the Japanese `JMdict_e` document,

diff --git a/app/.gitignore b/app/.gitignore
@@ -41,5 +41,3 @@ app.*.map.json
 
 # Exceptions to above rules.
 !/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages
-assets/dicts/*
-!assets/dicts/.gitkeep
diff --git a/app/assets/dicts/.gitkeep b/app/assets/dicts/.gitkeep
diff --git a/app/assets/dicts/dict_ja.json b/app/assets/dicts/dict_ja.json
diff --git a/tool/ci/run_dict_parser.sh b/tool/ci/run_dict_parser.sh