Add trailing slash to urls to avoid redirects #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the result of a recent change to
api.open.fec.gov
or if it has always been that way, but currently requests to urls likehttps://api.open.fec.gov/v1/candidates
get redirected to urls likehttps://api.open.fec.gov/v1/candidates/
before they return a response. Therequests
library takes care of this for us by following redirects. Unfortunately, both the original request and the redirected request count against the user's API rate limit. That means users of the pyopenfec library can only make 500 meaningful requests per hour with the FEC's default 1000 request/hour rate limit.This PR addresses the issue by adding a trailing slash when the url is created. This could potentially cause problems if either a
resource
has a trailing slash in it or if there is a resource onapi.open.fec.gov
that does not expect a trailing slash. However, currently there are instances of resources in the pyopenfec code base that have a trailing slash and all the resources listed athttps://api.open.fec.gov/developers/
contain a trailing slash.