Tidy types

Signed-off-by: Andrew Shirley <andrew.shirley@sainsburys.co.uk> Signed-off-by: blam <ben@blam.sh>
jeremyguarini · Jul 14, 2021 · 76fcd5a · 76fcd5a
1 parent dc05501
commit 76fcd5a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/plugins/jenkins-backend/src/types.ts b/plugins/jenkins-backend/src/types.ts
@@ -15,9 +15,9 @@
  */
 
 export interface ScmDetails {
-  url?: String;
-  displayName?: String;
-  author?: String;
+  url?: string;
+  displayName?: string;
+  author?: string;
 }
 
 interface CommonBuild {

diff --git a/plugins/jenkins/src/api/JenkinsApi.ts b/plugins/jenkins/src/api/JenkinsApi.ts
@@ -124,7 +124,7 @@ export class JenkinsClient implements JenkinsApi {
   async getProjects(
     entity: EntityName,
     filter: { branch?: string },
-  ): Promise<any> {
+  ): Promise<Project[]> {
     const url = new URL(
       `${await this.discoveryApi.getBaseUrl('jenkins')}/v1/entity/${
         entity.namespace
@@ -157,7 +157,7 @@ export class JenkinsClient implements JenkinsApi {
     entity: EntityName,
     jobName: string,
     buildNumber: string,
-  ): Promise<any> {
+  ): Promise<Build> {
     const url = `${await this.discoveryApi.getBaseUrl('jenkins')}/v1/entity/${
       entity.namespace
     }/${entity.kind}/${entity.name}/job/${encodeURIComponent(