Remove deprecated should_not raise_error(SpecificError).
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes look good. I'll run them through the test suite tomorrow and commit them if there is no fallout. Thanks for the help. |
Add an explanatory message so that it's easy to learn what's going on.
|
You're welcome. I wanted to hack a bit and just noticed these. |
|
The spec changes look good. I'm against changing the default rake task, but not strongly. If you think it should be changed, you should open a thread on sequel-talk and see if the community supports such a change. |
|
I've merged 9dd5453. I'm closing this now. If the community is in favor of the Rakefile change, I'll handle that separately. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. rspec/rspec-expectations#231
Note that removed lines in
hooks_spec.rbare redundant.