Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closeOnOverlayTap not working with alwaysOpen prop #151

Closed
WesleyFaveri opened this issue Mar 18, 2020 · 5 comments
Closed

closeOnOverlayTap not working with alwaysOpen prop #151

WesleyFaveri opened this issue Mar 18, 2020 · 5 comments
Labels
🤕 Valid issue Something isn't working

Comments

@WesleyFaveri
Copy link
Contributor

When i open full modal with alwaysOpen prop then click on overlay, it doesnt close, i can focus textinput and etc.
@jeremybarbet
Copy link
Owner

That's correct, I can reproduce that. I will look into if I find time, feel free to open PR if you find the issue first!

@jeremybarbet jeremybarbet added the 🤕 Valid issue Something isn't working label Mar 19, 2020
WesleyFaveri added a commit to WesleyFaveri/react-native-modalize that referenced this issue Mar 19, 2020
@WesleyFaveri
feat: added param to close overlay and condition to pointerEvents jer…
8286cc8 
…emybarbet#151
@WesleyFaveri
Copy link
Contributor Author

#152

jeremybarbet pushed a commit that referenced this issue Mar 20, 2020
@WesleyFaveri
feat: added param to close overlay and condition to pointerEvents #151 (
92db47b 
#152)
jeremybarbet added a commit that referenced this issue Mar 20, 2020
@jeremybarbet
Revert "feat: added param to close overlay and condition to pointerEv…
60a5e70 
…ents #151 (#152)"

This reverts commit 92db47b.
@jeremybarbet
Copy link
Owner

I will release a new rc version straight after finishing merging PRs :) Thank you for fixing this and opening PR, really appreciated!

@seyedasfar
Copy link

seyedasfar commented Jun 13, 2020 •
edited
Loading

has this bug fixed?

@Ilya1995
Copy link

Ilya1995 commented Dec 9, 2020

I cannot close the modal with a swipe if there is alwaysOpen prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤕 Valid issue Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeremybarbet @Ilya1995 @WesleyFaveri @seyedasfar