Fully isolate windows.h includes to source files#323
Fully isolate windows.h includes to source files#323jeremy-rifkin merged 2 commits intojeremy-rifkin:mainfrom
Conversation
|
Converting to draft until the failing CI checks can be resolved |
|
https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-exception_pointers seems to indicate the definition comes from winnt.h but https://learn.microsoft.com/en-us/cpp/cpp/try-except-statement?view=msvc-170 indicates it comes from excpt.h, but if CI passes I'm happy to take that as a good sign excpt.h is correct |
|
Yeah, apologies for not elaborating at all on that. The actual definition of |
|
Perfect thanks! That gives me more confidence in the portability of this |
windows.hhas a lot of transitive includes, and subsequently undesired macro definitions, that are not required for cpptrace's functionality. This change simply substituteswindows.hforexcpt.hinfrom_current.hpp, fully isolatingwindows.hincludes to cpptrace source files.ctest passed locally on: