Skip to content

Conversation

@FrancoisPgm
Copy link

Add a UUID for the callback contexts, the same id is shared through the whole task tree.

I also added a sanity test for the subcontext method, and in order to check the propagation of the uuid in the task tree I updated the _make_task_tree function in the tests to use _from_parent instead of _from_estimator.

…e _from_parent instead of _from_estimator in _make_task_tree for tests
@github-actions
Copy link

❌ Linting issues

This PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling pre-commit hooks. Instructions to enable them can be found here.

You can see the details of the linting issues under the lint job here


cython-lint

cython-lint detected issues. Please fix them locally and push the changes. Here you can see the detected issues. Note that the installed cython-lint version is cython-lint=0.18.1.


/home/runner/work/scikit-learn/scikit-learn/sklearn/cluster/_hdbscan/_tree.pyx:786:19: unnecessary set + generator (just use a set comprehension)

Generated for commit: f0a5c91. Link to the linter CI: here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant