Skip to content

Conversation

@FrancoisPgm
Copy link

Add warnings and test for those warnings for situations where :

    1. a non callback supporting estimator is used in a callback supporting meta-estimator
    1. a callback supporting estimator is used in a non callback supporting meta-estimator

Right now the warnings for the 1st case work, but the test with n_jobs=2 and prefer="processes" fails although when trying in the terminal I do see the warning, so I think it is an issue with the way pytest handles subprocesses.

For the second case, the warnings don't work when there is parallelization (n_jobs=2), because the children threads cannot access the stack from the parent thread. I'm not sure there is a way to bypass that limitation.

…in a callback supporting meta-estimator and vice-versa
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

❌ Linting issues

This PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling pre-commit hooks. Instructions to enable them can be found here.

You can see the details of the linting issues under the lint job here


cython-lint

cython-lint detected issues. Please fix them locally and push the changes. Here you can see the detected issues. Note that the installed cython-lint version is cython-lint=0.18.0.


/home/runner/work/scikit-learn/scikit-learn/sklearn/cluster/_hdbscan/_tree.pyx:786:19: unnecessary set + generator (just use a set comprehension)

Generated for commit: cbfb2e4. Link to the linter CI: here

… the non callback supporting estimator in subprocesses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant