Private fit function for callbacks #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Sep 30, 2025
sklearn/callback/tests/_utils.py
Outdated
| def fit(self, X_train=None, y_train=None, X_val=None, y_val=None): | ||
| if isinstance(self, CallbackSupportMixin): | ||
| callback_ctx = self.init_callback_context() | ||
| callback_ctx.eval_on_fit_begin(estimator=self) |
Owner
There was a problem hiding this comment.
on_fit_begin should be called in __skl_fit__ imo.
sklearn/callback/tests/_utils.py
Outdated
| BaseEstimator class. | ||
| """ | ||
|
|
||
| @_fit_context(prefer_skip_nested_validation=False) |
Owner
There was a problem hiding this comment.
Let's test what it looks like to extract the content of the decorator and put it inside fit.
sklearn/callback/tests/_utils.py
Outdated
Comment on lines
84
to
86
| ): | ||
| for i in range(self.max_iter): | ||
| subcontext = callback_ctx.subcontext(task_id=i) | ||
| if callback_ctx is not None: |
Owner
There was a problem hiding this comment.
We need a new method, like set_task_info, to set max_subtasks, task_name and task_id here, now that init_callback_context has moved.
callback_ctx.set_task_info(...)
sklearn/callback/tests/_utils.py
Outdated
Comment on lines
83
to
86
| self, X_train=None, y_train=None, X_val=None, y_val=None, callback_ctx=None | ||
| ): | ||
| for i in range(self.max_iter): | ||
| subcontext = callback_ctx.subcontext(task_id=i) | ||
| if callback_ctx is not None: |
Owner
There was a problem hiding this comment.
callback context cannot be None since we intialize it in fit and pass it to __skl_fit__.
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb
reviewed
Oct 1, 2025
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
…it-learn into private_fit_for_callbacks
…s merged with its parent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the private
__skl_fit__method for the estimators used for the callbacks.