Skip to content

Conversation

@FrancoisPgm
Copy link

Add a MetricMonitor callback class to log a metric during fitting.

Not sure about the name though, I was thinking about ErrorMetricMonitor or ScoreMetricMonitor. Also "Monitor" could be changed to "Logger".

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 59fc76e. Link to the linter CI: here

@FrancoisPgm
Copy link
Author

@jeremiedbb

@FrancoisPgm
Copy link
Author

The current version passes the callback tests when running them without pytest parallelization. But whit the pytest parallellization it can happen that some items logged by the MetricMonitor get lost when tested on a cloned estimator in a meta estimator. Sometimes also the tests seem to get stuck forever, probably a deadlock in the MetricMonitor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant