-
Notifications
You must be signed in to change notification settings - Fork 38
handle full cells that starts with a discharge step #359
Copy link
Copy link
Open
Labels
cellpy2-stage5cellpy 2.2 (Stage 5): live/incremental, step/summary science, loaders/IO, remote/discoverycellpy 2.2 (Stage 5): live/incremental, step/summary science, loaders/IO, remote/discoveryto coreImplementation should be done in cellpy-coreImplementation should be done in cellpy-corev2cellpy v2 work - PRs should target the master branchcellpy v2 work - PRs should target the master branch
Milestone
Description
Metadata
Metadata
Assignees
Labels
cellpy2-stage5cellpy 2.2 (Stage 5): live/incremental, step/summary science, loaders/IO, remote/discoverycellpy 2.2 (Stage 5): live/incremental, step/summary science, loaders/IO, remote/discoveryto coreImplementation should be done in cellpy-coreImplementation should be done in cellpy-corev2cellpy v2 work - PRs should target the master branchcellpy v2 work - PRs should target the master branch
We typically define the coulombic efficiency as charge/discharge. One exception is half-cells studying an anode material (where coulombic efficiency makes more sense if it is defined as discharge/charge). Therefore,
cellpy'scycle_modeparameter was implemented to control how coulombic efficiency is calculated. It is also used (at least for default settings) in defining how charge and discharge curves are extracted and visualized.A common pitfall is when testing commercial cells, where one might start with a discharge (cycle 1) and then continue with charge-discharge cycles (cycles 2, 3, 4, ...). It is likely that some files end up with an "erroneous" cycle counter (could be that the first cycle is discharge-charge-discharge, or that all cycles end up as discharge-charge).
Is there a method in
cellpyto handle these cases? If not, could it be implemented (e.g. either as another alternative for thecycle_modeparameter, or some post-processing steps like `update_cycle_counter(...))?