Add input validation to StandardAgent.solve() - Fixes #76 #100
Conversation
- Validate goal parameter is not None or empty/whitespace - Raise ValueError with descriptive messages for invalid inputs - Add comprehensive unit tests for validation logic - All existing tests continue to pass Fixes jentic#76
| def solve(self, goal: str) -> ReasoningResult: | ||
| """Solves a goal synchronously (library-style API).""" | ||
|
|
||
| if goal is None: |
There was a problem hiding this comment.
Thanks for the contribution! I appreciate you thinking about input validation—it's definitely something we should handle better.
I'd like to suggest a small refinement to make the UX even better. Instead of raising a ValueError, what do you think about returning a graceful result like this?
if not goal or not goal.strip(): return ReasoningResult(success=False, final_answer="Goal cannot be empty, please provide a goal")
My reasoning: In user-facing scenarios (chat interfaces, APIs, etc.), raising an exception forces the caller to handle it with try/except. Returning a failed ReasoningResult keeps the flow consistent—the caller always gets a result object, whether the input was valid or not.
Would like to hear your thoughts on this.
Thanks again for taking the time to improve the codebase! 🚀
2 participants
Closes #76
This PR adds input validation to the
solve()method as requested in the issue:The implementation follows the existing code patterns and testing conventions.