Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and speedup box bonding #110

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Fix and speedup box bonding #110

merged 2 commits into from
Dec 3, 2020

Conversation

speleo3
Copy link
Collaborator

@speleo3 speleo3 commented Dec 2, 2020

First commit fixes #97.
Second commit makes box bonding 5 times faster.

Was only populating 8 out of 14 necessary boxes.

Fixes #97
5x speedup of `find_bonds_for_molecules_using_boxes`
@speleo3 speleo3 requested a review from sobolevnrm December 2, 2020 07:58
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #110 (c78345c) into master (45aa08a) will decrease coverage by 0.22%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   73.31%   73.09%   -0.23%     
==========================================
  Files          24       24              
  Lines        3987     3958      -29     
==========================================
- Hits         2923     2893      -30     
- Misses       1064     1065       +1     
Impacted Files Coverage Δ
propka/bonds.py 55.40% <96.42%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45aa08a...c78345c. Read the comment docs.

Copy link
Collaborator

@sobolevnrm sobolevnrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! FWIW, I've been using https://docs.scipy.org/doc/scipy/reference/generated/scipy.spatial.KDTree.html for most of my distance lookups lately at it works great. It's not the right solution for this (overkill and don't want to introduce additional dependencies) but thought I'd share the finding, regardless.

@speleo3
Copy link
Collaborator Author

speleo3 commented Dec 2, 2020

I fully agree, scipy.spatial.KDTree is fantastic, but scipy is a pretty hefty dependency.

@speleo3 speleo3 merged commit 31b41c3 into master Dec 3, 2020
@speleo3 speleo3 deleted the fix-97-speedup-box-bonding branch December 3, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: "IndexError: list index out of range" with a specific pdb file
2 participants