Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude symbol-annotations as it's coming from the core #18

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

batmat
Copy link
Member

@batmat batmat commented Jan 5, 2021

Without this, when bumping credentials to 2.3.14 e.g. this breaks:

[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (display-info) @ variant ---
[INFO] Adding ignore: module-info
[WARNING] Rule 4: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for org.jenkins-ci:symbol-annotation:1.1 paths to dependency are:
+-org.jenkins-ci.plugins:variant:1.4-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.249.1
    +-org.jenkins-ci:symbol-annotation:1.1
and
+-org.jenkins-ci.plugins:variant:1.4-SNAPSHOT
  +-org.jenkins-ci.plugins:credentials:2.3.14
    +-org.jenkins-ci.plugins:structs:1.20
      +-org.jenkins-ci:symbol-annotation:1.20

This is needed by #13

Without this, *when* bumping credentials to 2.3.14 e.g. this breaks:

```
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (display-info) @ variant ---
[INFO] Adding ignore: module-info
[WARNING] Rule 4: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for org.jenkins-ci:symbol-annotation:1.1 paths to dependency are:
+-org.jenkins-ci.plugins:variant:1.4-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.249.1
    +-org.jenkins-ci:symbol-annotation:1.1
and
+-org.jenkins-ci.plugins:variant:1.4-SNAPSHOT
  +-org.jenkins-ci.plugins:credentials:2.3.14
    +-org.jenkins-ci.plugins:structs:1.20
      +-org.jenkins-ci:symbol-annotation:1.20
```
@batmat batmat merged commit 9483b45 into jenkinsci:master Jan 5, 2021
@batmat batmat deleted the fix-symbol-annotation-dep-pull branch January 5, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant