Skip to content

Removed 3 unnecessary stubbings in ChangesSinceLastBuildMacroTest.java #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slide merged 4 commits into from
Oct 27, 2023
Merged

Removed 3 unnecessary stubbings in ChangesSinceLastBuildMacroTest.java #201

slide merged 4 commits into from
Oct 27, 2023

Conversation

@ARUS2023
Copy link
Contributor

@ARUS2023 ARUS2023 commented Oct 20, 2023

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

In our previous pull request #194, we forgot to remove 3 unnecessary stubbings in the method createBuild. We are submitting this pull request to remove those. Sorry we did not submit all of them at one.

slide
slide reviewed Oct 20, 2023
View reviewed changes
src/test/java/org/jenkinsci/plugins/tokenmacro/impl/ChangesSinceLastBuildMacroTest.java Outdated
private AbstractBuild createBuild2(Result result, int buildNumber, String message) {
AbstractBuild build = mock(AbstractBuild.class);
ChangeLogSet changes1 = createChangeLog2(message);

Copy link
Member

@slide slide Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra whitespace here.

Copy link
Contributor Author

@ARUS2023 ARUS2023 Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out, we removed it.

@slide slide merged commit f704dc3 into jenkinsci:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slide slide slide approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ARUS2023 @slide