Fix "Invalid cookie header" warnings #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sghill could you have a look at this? :-) |
|
@offa is it possible to add a test that verifies this behavior? MockServer or similar may be useful here |
|
Thanks, I'll have a look at it! |
offa
commented
Aug 22, 2023
| @@ -530,7 +531,8 @@ protected CloseableHttpClient getHttpClient(PrintStream logger, Run<?, ?> run, S | |||
| RequestConfig.Builder requestBuilder = RequestConfig.custom() | |||
| .setSocketTimeout(timeoutInMilliseconds) | |||
| .setConnectTimeout(timeoutInMilliseconds) | |||
| .setConnectionRequestTimeout(timeoutInMilliseconds); | |||
| .setConnectionRequestTimeout(timeoutInMilliseconds) | |||
There was a problem hiding this comment.
According to usage search, the function isn't used anymore and deprecated. Thus, instead of adding tests to these changes, I can drop them. What do you think?
There was a problem hiding this comment.
It seems low risk so I think we can leave it. If there is an issue we can revert.
|
@sghill Test added (for the not-deprecated version; see comments above). |
sghill
approved these changes
Aug 22, 2023
| @@ -530,7 +531,8 @@ protected CloseableHttpClient getHttpClient(PrintStream logger, Run<?, ?> run, S | |||
| RequestConfig.Builder requestBuilder = RequestConfig.custom() | |||
| .setSocketTimeout(timeoutInMilliseconds) | |||
| .setConnectTimeout(timeoutInMilliseconds) | |||
| .setConnectionRequestTimeout(timeoutInMilliseconds); | |||
| .setConnectionRequestTimeout(timeoutInMilliseconds) | |||
There was a problem hiding this comment.
It seems low risk so I think we can leave it. If there is an issue we can revert.
src/test/java/org/jenkinsci/plugins/stashNotifier/DefaultApacheHttpNotifierTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each status update sent to Bitbucket issues a warning in the Jenkins log:
This PR fixes the issue.
Testing done
Verified on a Jenkins instance.
Submitter checklist