Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-35551] Upgrade to Credentials v2 #310

Merged
merged 1 commit into from
May 17, 2022

Conversation

offa
Copy link
Contributor

@offa offa commented May 13, 2022

A first effort of Credentials v2 (#138, JENKINS-35551).

I'm not very familiar with the API, most of it is based on the credentials docs and the linked issues. I'd appreciate someone with experience having a look at it – even more as it's security related.


  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@offa
Copy link
Contributor Author

offa commented May 17, 2022

/cc @stephenc

Copy link
Member

@scaytrase scaytrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scaytrase scaytrase merged commit 7d83627 into jenkinsci:release/1.x May 17, 2022
@scaytrase
Copy link
Member

thanks @offa !

@offa offa deleted the jenkins-35551-credentials_v2 branch May 17, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants