Skip to content

Remove problematic maven-compiler-plugin configuration #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

jakub-bochenski
Copy link

The source and target should be configured via java.level
which is used by the parent pom.

The `source` and `target` should be configured via `java.level`
which is used by the parent pom.
Copy link

@proski proski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Maven maven ;) but I was able to check that the PR builds with mvn package on Fedora 29. Looks good to me.

@jimklimov
Copy link

Merging PR #37 introduced a merge conflict for this one, so I resolved that.

@jakub-bochenski jakub-bochenski merged commit 13f3d53 into master Feb 14, 2019
@jakub-bochenski jakub-bochenski deleted the jakub-bochenski-patch-3 branch August 9, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants