Update jenkinsci repository with PRs merged into original author's repo #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s defined as Java parameters (-DproxyHost -DproxyPort -Dhttp.proxy..., -Dhttp.nonProxyHosts, ...)
Before this commit, if you attempted to use the Stash pull-request builder plug in with Jenkins Pipeline, you would encounter an error. Ultimately, this error was due to the fact that this plug in require jobs to use the AbstractProject base class, but the Jenkins Pipeline job class (WorkflowJob) doesn't. The good news is that WorkflowJob and AbstractProject share a base class of Job, and that most functionality of this plug in can be made available to WorkflowJob refactoring uses of AbstractProject to uses of Job instead. For cases where this does not provide enough functionality, there are interfaces implemented in common by both (ParameterizedJobMixIn.ParameterizedJob, Queue.Task) that fill the gaps. The one remaining piece of functionality this commit does not extend to be available to Jenkins Pipeline is custom post-build comments, so a TODO to that effect was added.
Add release
Update to Apache httpclient 4.5.2. This allows to use proxies settings
Add support for Jenkins Pipeline.
|
Pinging @nemccarthy as the only maintainer, to get this PR moving forward :) |
|
I would rather review them and possibly integrate one by one. |
jakub-bochenski
force-pushed
the
master
branch
2 times, most recently
from
9c4d199 to
84bbeb8
Compare
|
Makes sense to (update and) merge them separately... |
|
OK, closing this one then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nemccarthy "upstream" repository has integrated a couple of PRs from here and there, a year ago. Isn't it time to promote them onwards?