Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist method moved from Run#getFullDisplayName to HistoricalBuild#getFullDisplayName #576

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Whitelist method moved from Run#getFullDisplayName to HistoricalBuild#getFullDisplayName #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bd5746
Whitelist method moved from Run#getFullDisplayName to HistoricalBuild…
Vlatombe Aug 28, 2024
b12683a
Fix soft dep to new core
Vlatombe Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/jenkins-whitelist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,5 @@ method hudson.tools.ToolInstallation getHome
method hudson.tools.ToolInstallation getName
method jenkins.model.CauseOfInterruption getShortDescription
method jenkins.model.CauseOfInterruption$UserInterruption getUserId
method jenkins.model.HistoricalBuild getFullDisplayName
staticField jenkins.model.Jenkins VERSION
4 changes: 3 additions & 1 deletion ...est/java/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/StaticWhitelistTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@
new MethodSignature(MatchResult.class, "group", String.class),
new MethodSignature(MatchResult.class, "hasMatch"),
new MethodSignature(MatchResult.class, "namedGroups"),
new MethodSignature(MatchResult.class, "start", String.class)
new MethodSignature(MatchResult.class, "start", String.class),
// TODO Do not exist until Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674

Check warning on line 159 in src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/StaticWhitelistTest.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
Do not exist until Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674
new MethodSignature("jenkins.model.HistoricalBuild", "getFullDisplayName")
));

@Test public void sanity() throws Exception {
Expand Down