Adapt standard Jenkins icons #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
force-pushed
the
update-icons
branch
from
eed86a9
to
0b89b4a
Compare
NotMyFault
commented
Jan 4, 2024
| @@ -61,7 +61,7 @@ THE SOFTWARE. | |||
| </td> | |||
| <td> | |||
| <a href="${b.url}console"> | |||
| <img src="${imagesURL}/${subIconSize}/terminal.gif" title="${%Console output}" alt="${%Console output}" border="0" /> | |||
| <l:icon class="icon-sm" src="symbol-terminal" tooltip="${%Console output}" /> | |||
There was a problem hiding this comment.
No idea where GH takes the tabs from, looks fine in the IDE 🤷
There was a problem hiding this comment.
your ide will be hiding it, if you reformat the file it would fix it but not worried for this project.
|
@timja Do you think you can cut a release including this change? RPU lists you with release perms regardless the adoption state 👀 |
timja
approved these changes
Jan 5, 2024
|
Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change proposed adapts the standard Jenkins icons (ionicons) used in core itself. In this case, the icons look most the same, but ionicons support our theme-ability API and are recommended to use.