Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-64341] Fix for tables-to-divs #9

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

dariver
Copy link
Contributor

@dariver dariver commented Feb 17, 2021

Jira: JENKINS-64341

What has been done

  1. Fix for tables-to-div regression

Screenshots

Before After
before-job after-job
before-global-config after-global-config

How to test

  1. Check configuration in Manage Jenkins > Configure system
  2. Create a Freestyle job, add a new build step action and fill the values
  3. Save and verify that all the values were persisted.

@dariver
Copy link
Contributor Author

dariver commented Feb 17, 2021

cc @timja, @fqueiruga, @fbelzunc

@@ -66,14 +66,14 @@
<j:scope>
<j:set var="descriptor" value="${descriptor.transferDescriptor}"/>
<f:repeatable items="${instance.transfers}" var="instance" name="transfers" minimum="1" header="${m.transfers_dragAndDropLabel()}" add="${m.addTransfer()}">
<table width="100%" padding="0">
<p:blockWrapper>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't there more files that need changing? see https://github.com/jenkinsci/publish-over-ftp-plugin/search?q=table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups! You are totally right

@dariver
Copy link
Contributor Author

dariver commented Feb 17, 2021

It seems that this PR contains the same changes in #8.

Feel free to close this and merge the other.

@oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev merged commit 5cc8530 into jenkinsci:master Mar 11, 2021
@gmcdonald gmcdonald added the skip-changelog Do not include this PR in the next release label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Do not include this PR in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants